[PATCH v2] linux-gen: include git tag in implementation string #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
MatiasElo
reviewed
Feb 26, 2025
odp_version_impl_str() output simplified as previously version was displayed thrice. odp_version_impl_str() returns either in format "odp-linux-1.46.0.0-16a27d99", or "odp-linux-1.46.0.0" in the case that the commit hash could not be retrieved. Signed-off-by: Ray Sointula <[email protected]> Reviewed-by: Matias Elo <[email protected]>
Rayska
force-pushed
the
include_git_tag
branch
from
16a27d9 to
b058177
Compare
odpbuild
changed the title
MatiasElo
reviewed
Feb 27, 2025
| ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR) ") " \ | ||
| ODP_VERSION_TO_STR(ODP_VERSION_BUILD) | ||
| _ODP_IMPLEMENTATION_NAME "-" \ | ||
| ODP_VERSION_TO_STR(ODP_VERSION_BUILD) _ODP_GIT_REVISION \ |
There was a problem hiding this comment.
Extra backslash at the end. Also, the implementation version string could be formed directly in odp_version_impl_str() without adding this ODP_VERSION_IMPL_STR define.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odp_version_impl_str() output simplified as previously version was
displayed thrice.
odp_version_impl_str() returns either in format
"odp-linux-1.46.0.0-16a27d99", or "odp-linux-1.46.0.0" in the case that
the commit hash could not be retrieved.
This uses the system default shell, any POSIX-compliant shell should be fine.