[PATCH v1] [RFC] fdserver executable #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 21, 2018 13:29
fdserver can be run a an external application, rather than as part of the ODP library. Signed-off-by: Josep Puigdemont <[email protected]>
Signed-off-by: Josep Puigdemont <[email protected]>
Signed-off-by: Josep Puigdemont <[email protected]>
Signed-off-by: Josep Puigdemont <[email protected]>
The fdserver binary is now retrieved from the configuration file itself, like the socket to use. This required the odp-$(with_platform).conf file to be built by automake from a template in order to honor the installation path provided at configuration time. FIXME: this is not the correct way of doing this, the configuration file should be part of the build tree, instead it is part of the source tree. This needs to be fixed. Signed-off-by: Josep Puigdemont <[email protected]>
muvarov
changed the title
|
@JannePeltonen Please review to see if this addresses Issue #563 for you. |
|
@Bill-Fischofer-Linaro I cannot review the patch since it is quite large and I am not familiar with the fdserver and ishm implementations. This seems like a reimplementation of fdserver and not just something that changes the current implementation to a separate executable. I wonder if both changes are good to do in single patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to solve issue #563 by moving fdserver outside of the ODP library and into an external application.
The
fdserver_*API has changed a bit and is not yet documented (it wasn't before anyway). For instance, the "contexts" used were previously hardcoded in an enumeration, now they can be created at run-time.This is just an RFC, tests won't pass because they are actually unable to find the fdserver binary (could be solved by providing a run-time configuration file).