Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package/libmodplug: Add a patch fixing cctype UB #110

Closed
wants to merge 1 commit into from

Conversation

glebm
Copy link

@glebm glebm commented Dec 23, 2022

Also sent upstream Konstanty/libmodplug#92

Fixes #105

@glebm
Copy link
Author

glebm commented Jan 1, 2023

Upstream buildroot now also uses the git version of libmodplug as of buildroot@369ff9a

Will send them this patch also

@glebm
Copy link
Author

glebm commented Jan 9, 2023

@pcercuei
Copy link
Member

Looks like neither upstream libmodplug nor buildroot are very interested in the patch.

Could you move it to board/opendingux/patches/libmodplug, so that it doesn't cause merge issues if it's eventually accepted upstream?

@glebm
Copy link
Author

glebm commented Mar 24, 2023

Done in #122 (also added the patches that fix unaligned reads)

@glebm glebm closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playing mod music files often results in a crash
2 participants