Don't throw WarningCode.EmptyBlock on semicolon bodies
#1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeWaka
commented
Oct 15, 2023
| /// This is used to determine if we should flag for <c>WarningCode.EmptyBlock</c>, | ||
| /// which we don't do if there was a manually entered semicolon within. | ||
| /// </summary> | ||
| public bool NotCompletelyEmpty; |
There was a problem hiding this comment.
definitely open to a wording change on this
| @@ -2616,5 +2639,19 @@ public partial class DMParser : Parser<Token> { | |||
|
|
|||
| return hasDelimiter; | |||
| } | |||
|
|
|||
| private bool DelimiterHasSemicolon(ref bool hasSemicolon) { | |||
note |
ZeWaka
force-pushed
the
feature/empty-block-semicolon
branch
from
cc85bee to
d63de28
Compare
|
Closing in favor of #1670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially, throw
WarningCode.EmptyBlockonbut not
This way, developers can insert a semicolon to denote that they intentionally want to write a statement a certain way.
this is pretty cursed code, but it's the only really viable way i could see how to do this