Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implement splittext and add test #1560

Merged
merged 10 commits into from
Jan 7, 2024

Conversation

amylizzle
Copy link
Contributor

Slight BYOND parity break due to what looks like a bug https://www.byond.com/forum/post/2904976

@amylizzle amylizzle marked this pull request as ready for review December 22, 2023 16:52
Content.Tests/DMProject/Tests/Text/Splittext.dm Outdated Show resolved Hide resolved
OpenDreamRuntime/Procs/Native/DreamProcNativeRoot.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Procs/Native/DreamProcNativeRoot.cs Outdated Show resolved Hide resolved
@amylizzle amylizzle requested a review from wixoaGit January 7, 2024 10:40
var/test_text = "The average of 1, 2, 3, 4, 5 is: 3"
var/list/test1 = splittext(test_text, " ")
var/list/test1_expected = list("The","average","of","1,","2,","3,","4,","5","is:","3")
test1 ~= test1_expected
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to ASSERT()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm an idiot

@wixoaGit wixoaGit enabled auto-merge (squash) January 7, 2024 17:35
@wixoaGit wixoaGit merged commit d83ae6d into OpenDreamProject:master Jan 7, 2024
6 checks passed
@amylizzle amylizzle deleted the splittext branch January 7, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants