Halve the renderer's allocation rate #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently you can't set the shader outside `RenderInRenderTarget()`. A little saddening, but not a huge hit to allocation rate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some renderer optimizations with a focus on memory allocation rate.
DrawIconAction()(nowDrawIcon()) into several methods (ProcessKeepTogether(),DrawIconFast(), andDrawIconSlow()) so it no longer holds any lambdas. The C# compiler was allocating the lambdas' closures even though the closures weren't used in a majority of cases. Now they're only allocated when necessary.DrawIcon()now draws the icon directly instead of returning two actions for drawing the icon and its mouse map. This allows for less lambda usage.Before:
After:
Large majority of allocations now are in shader setup,
GetBlendAndColorShader()