Complete rework of verbs #1633
Merged
Complete rework of verbs #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A list of all verbs are now sent to the client It is up to the client to decide what verbs should be executable and displayed to the user (with server verification Coming Soon) Client is responsible to collecting/parsing verb arguments before asking the server to execute it
Verbs rely on an entity system now, which our unit tests don't initialize
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # OpenDreamClient/Interface/DreamInterfaceManager.cs # OpenDreamRuntime/DreamConnection.cs # OpenDreamShared/Network/Messages/MsgPrompt.cs
|
Would allowing #1077 be in the scope of this? |
I'm not going to do anything further in this PR, it's fairly large as it is. I can do it in my next verb-related PR though which will be soon after. |
wixoaGit
commented
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of preliminary work for more complete verb support (and some postliminary work as well).
A list of all verbs are now sent to the client, and it is up to the client to decide what verbs should be executable and displayed to the user. Using this I also added support for executing verbs by right-clicking a target and selecting a verb that applies to it. Right now "verb that applies to it" only means something in its
verbslist because I haven't added support forset src = ....Things still left to do:
set src = ...in list()argumentsdefault_verb_categoryWow I can rotate a chair without pressing alt
Wow I can flip a table
Wow I can pick up a specific shard from this huge pile of shards
Wow I can close #245