Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size labelling to PRs #1663

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Conversation

amylizzle
Copy link
Contributor

I always like this feature on repos, so we should have it too.
Gotta create the labels tho:

Create the needed labels

Export both GITHUB_TOKEN and REPO (e.g. my-username/my-repository) and run the script below:

for size in XL XXL XS S M L; do
  curl -sf -H "Authorization: Bearer $GITHUB_TOKEN" "https://api.github.com/repos/kubernetes/kubernetes/labels/size/$size" |
    jq '. | { "name": .name, "color": .color, "description": .description }' |
    curl -sfXPOST -d @- -H "Authorization: Bearer $GITHUB_TOKEN" https://api.github.com/repos/$REPO/labels
done

@wixoaGit
Copy link
Member

wixoaGit commented Feb 8, 2024

Could we put this, #1664, and conflict-labeler.yml all in one workflow?

@ZeWaka
Copy link
Collaborator

ZeWaka commented Feb 8, 2024

Could we put this, #1664, and conflict-labeler.yml all in one workflow?

No, because #1664 isn't a workflow, it's a GitHub App

@wixoaGit
Copy link
Member

wixoaGit commented Feb 8, 2024

Could we put this, #1664, and conflict-labeler.yml all in one workflow?

No, because #1664 isn't a workflow, it's a GitHub App

What I was wondering is if we could put them in the same file/check.

If not (or it's unusual), I'd like conflict-labeler to have its name changed to something more specific than "Add Extra PR Labels"

@amylizzle
Copy link
Contributor Author

I don't actually think I can verify this in any way, but I've tried to combine size and merge conflict labelling. Just the what-files-were-touched one works differently.

@wixoaGit wixoaGit enabled auto-merge (squash) February 9, 2024 01:22
@wixoaGit wixoaGit merged commit 5666fa3 into OpenDreamProject:master Feb 9, 2024
7 checks passed
@amylizzle amylizzle deleted the size_label branch February 9, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants