Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes . in spawn() #1665

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Fixes . in spawn() #1665

merged 2 commits into from
Oct 13, 2024

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Feb 7, 2024

Fixes #1653

@ike709
Copy link
Collaborator Author

ike709 commented Feb 11, 2024

The failing tests are fixed when testing these changes on top of #1539, so merge that PR first.

@ike709
Copy link
Collaborator Author

ike709 commented Jun 12, 2024

Just going to leave this as a draft until #1539 is merged.

@ike709 ike709 marked this pull request as draft June 12, 2024 20:44
@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Oct 13, 2024
@ike709 ike709 marked this pull request as ready for review October 13, 2024 17:41
@ike709
Copy link
Collaborator Author

ike709 commented Oct 13, 2024

I have no idea why merging master fixed CI but I'll take it.

@ike709 ike709 requested a review from wixoaGit October 13, 2024 17:41
@wixoaGit wixoaGit merged commit c616f70 into OpenDreamProject:master Oct 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
Runtime Involves the OpenDream server/runtime size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

. value is not preserved in spawn()
2 participants
@ike709 @wixoaGit