Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opendream_noconstfold, add it to some world vars #2097

Merged
merged 3 commits into from
Nov 16, 2024
Merged

Add opendream_noconstfold, add it to some world vars #2097

merged 3 commits into from
Nov 16, 2024

Conversation

wixoaGit
Copy link
Member

@wixoaGit wixoaGit commented Nov 16, 2024 •
edited
Loading

world.opendream_topic_port was const-folding to null despite its value being set at runtime.

Fixes #2094
Fixes #2095

@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Nov 16, 2024
@wixoaGit wixoaGit enabled auto-merge (squash) November 16, 2024 04:07
@wixoaGit wixoaGit disabled auto-merge November 16, 2024 04:08
@wixoaGit wixoaGit enabled auto-merge (squash) November 16, 2024 04:08
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 16, 2024
View reviewed changes
DMCompiler/DM/Expressions/Dereference.cs Dismissed Show dismissed Hide dismissed
@wixoaGit wixoaGit merged commit c0b9253 into OpenDreamProject:master Nov 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compiler Involves the OpenDream compiler size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

world.opendream_topic_port is being const-folded to null world.system_type should be const but isn't
1 participant
@wixoaGit