Tracy #2127
Tracy #2127
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| [CVarDefs] | ||
| public abstract class OpenDreamCVars { | ||
| public static readonly CVarDef<string> JsonPath = | ||
| CVarDef.Create("opendream.json_path", String.Empty, CVar.SERVERONLY); |
Check notice
Code scanning / InspectCode
Replace built-in type reference with a CLR type name or a keyword in static member access expressions Note
| public static readonly CVarDef<int> DebugAdapterLaunched = | ||
| CVarDef.Create("opendream.debug_adapter_launched", 0, CVar.SERVERONLY); | ||
|
|
||
| public static readonly CVarDef<bool> SpoofIEUserAgent = |
Check warning
Code scanning / InspectCode
Inconsistent Naming Warning
|
|
||
| public DreamResource(int id, string? filePath, string? resourcePath) { | ||
| Id = id; | ||
| ResourcePath = resourcePath; | ||
| _filePath = filePath; | ||
| _tracyMemoryId = Profiler.BeginMemoryZone((ulong)(Unsafe.SizeOf<DreamResource>() + (ResourceData is null? 0 : ResourceData.Length)), "resource"); |
Check notice
Code scanning / InspectCode
Merge conditional ?: expression into conditional access Note
| #endif | ||
| } | ||
|
|
||
| public static ProfilerMemory? BeginMemoryZone(ulong size, string? name) |
Check warning
Code scanning / InspectCode
Return type of a function can be made non-nullable Warning
| @@ -17,6 +17,9 @@ | |||
| namespace OpenDreamRuntime.Objects { | |||
| [Virtual] | |||
| public class DreamObject { | |||
| #if TOOLS | |||
| protected ProfilerMemory? _tracyMemoryId; | |||
Check warning
Code scanning / InspectCode
Inconsistent Naming Warning
| @@ -19,16 +20,25 @@ | |||
|
|
|||
| private readonly string? _filePath; | |||
| private byte[]? _resourceData; | |||
| #if TOOLS | |||
| private ProfilerMemory? _tracyMemoryId; | |||
Check warning
Code scanning / InspectCode
Non-accessed field: Private accessibility Warning
with thanks to https://github.com/wixoaGit/OpenDreamFork/tree/tracy for doing most of the work
When in TOOLS build activates proc logging for DM with source locations.
also it does native procs so we can use it to make OD faster
Memory tracing:
Note: DreamObject memory footprint is not accurate. It assumes that each object allocates its total possible memory.