Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parity handling of null in various operators #2129

Merged
merged 6 commits into from
Jan 4, 2025

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Dec 10, 2024

See the moved unit tests.

Summary:

  • Bit shifting a LHS float and RHS null returns LHS as an integer
  • Bit masking any float and null returns 0
  • Bit XORing two nulls returns null
  • Bit XORing a LHS float and RHS null returns LHS as an integer
  • Bit XORing a LHS null and RHS float returns RHS as an integer
  • Dividing LHS by null now returns LHS. Fixes Dividing a number by null doesn't provide the correct result #2148
  • Fixed incorrect expected results in Division.dm

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Dec 10, 2024
@wixoaGit wixoaGit merged commit f6d9b55 into OpenDreamProject:master Jan 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Runtime Involves the OpenDream server/runtime size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dividing a number by null doesn't provide the correct result
2 participants