integrated tab status updates taking into account empty fields into t…

…he updateTabProgressIndicatorClasses() function #1650
OpenEnergyPlatform · Jun 17, 2024 · ca773c2 · ca773c2
1 parent 980448b
commit ca773c2
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/dataedit/static/peer_review/opr_reviewer.js b/dataedit/static/peer_review/opr_reviewer.js
@@ -937,8 +937,12 @@ function updateTabProgressIndicatorClasses() {
     if (!tab) continue;
 
     let fieldsInTab = Array.from(document.querySelectorAll('#' + tabName + ' .field'));
+    let values = getAllFieldsAndValues();
 
-    let allOk = fieldsInTab.every((field) => field.classList.contains('field-ok'));
+    let allOk = fieldsInTab.every((field, index) => {
+        let currentValue = values[index].fieldValue;
+        return isEmptyValue(currentValue) || field.classList.contains('field-ok');
+    });
 
     if (allOk) {
       tab.classList.add('status--done');
@@ -948,6 +952,7 @@ function updateTabProgressIndicatorClasses() {
   }
 }
 
+
 summaryTab.addEventListener('click', function() {
   toggleReviewControls(false);
   reviewContent.classList.toggle("tab-pane--100");