Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance UX in OpenPeerReview: Group metadata fields #1650

Open
1 task
jh-RLI opened this issue Apr 2, 2024 · 1 comment · Fixed by #1700 · May be fixed by #1684
Open
1 task

Enhance UX in OpenPeerReview: Group metadata fields #1650

jh-RLI opened this issue Apr 2, 2024 · 1 comment · Fixed by #1700 · May be fixed by #1684
Assignees
@bmlancien @jh-RLI
Labels
enhancement open peer review The open energy platform peer review Urgency-M urgency level: medium

Comments

@jh-RLI
Copy link
Contributor

jh-RLI commented Apr 2, 2024 •
edited
Loading

Description of the issue

All fields are currently displayed independently of each other:
image

Fields:
GeneralTab - Context (Object), Keywords (List), Language (List)

Spatial&TemporalTab - Timeseries (List of Objects)

SourcesTab - Source (List of Objects)

Ideas of solution

Group all fields together that belong to the same object (like source 1, 2, 3 ....)

Workflow checklist
@jh-RLI jh-RLI added enhancement Urgency-M urgency level: medium open peer review The open energy platform peer review labels Apr 2, 2024
@jh-RLI jh-RLI moved this to In Progress in Open Peer Review Apr 2, 2024
@bmlancien
Copy link
Contributor

Mockup of how the content inside the General tab could look like.

review-general

bmlancien added a commit that referenced this issue May 13, 2024
@bmlancien
add placeholder for opr categorization of metadata items #1650
5f5367f
mdvcode pushed a commit that referenced this issue Jun 3, 2024
Removing .DS_Store from the list #1650
a08898e
mdvcode pushed a commit that referenced this issue Jun 3, 2024
Removing contributor tab from peer review #1650
184f048
@Darynarli Darynarli mentioned this issue Jun 3, 2024
Merged
5 tasks
@Darynarli Darynarli linked a pull request Jun 3, 2024 that will close this issue
Enhance OPR Process #1700
Merged
5 tasks
Darynarli pushed a commit that referenced this issue Jun 6, 2024
add a function to check for empty fields #1650
29febd7
Darynarli pushed a commit that referenced this issue Jun 6, 2024
add a functionality to deactivate review buttons for empty fields #1650
43098ec
Darynarli pushed a commit that referenced this issue Jun 6, 2024
add a function for getting all fields and their values #1650
0bce2e1
Darynarli pushed a commit that referenced this issue Jun 6, 2024
corrected function checkReviewComplete() considering empty fields #1650
bcb1899
Darynarli pushed a commit that referenced this issue Jun 17, 2024
corrected function checkFieldStates() considering empty fields #1650
980448b
Darynarli pushed a commit that referenced this issue Jun 17, 2024
integrated tab status updates taking into account empty fields into t…
ca773c2 
…he updateTabProgressIndicatorClasses() function #1650
jh-RLI added a commit that referenced this issue Jun 19, 2024
@jh-RLI
update changelog #1650
4822a9d
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open Peer Review Jun 19, 2024
@jh-RLI jh-RLI reopened this Jun 20, 2024
@jh-RLI jh-RLI moved this from Done to In Progress in Open Peer Review Jun 20, 2024
@jh-RLI jh-RLI linked a pull request Jun 20, 2024 that will close this issue
Draft
5 tasks
Darynarli pushed a commit that referenced this issue Jun 27, 2024
explanation to the reviewer about the impossibility of reviewing an e…
198bcef 
…mpty field #1650
Darynarli pushed a commit that referenced this issue Jul 3, 2024
corrected fieldValue in the summary table #1650
c1ea926
Darynarli pushed a commit that referenced this issue Jul 3, 2024
corrected fieldValue in the summary table on the contributor page #1650
8d6cbf8
mdvcode pushed a commit that referenced this issue Jul 10, 2024
correct sorting of empty fields on the summary page #1650
c5fc815
mdvcode pushed a commit that referenced this issue Jul 16, 2024
correct sorting of empty fields on the summary page #1650
e2b98f5
mdvcode pushed a commit that referenced this issue Jul 16, 2024
correct field name on the summary page #1650
6f36462
mdvcode pushed a commit that referenced this issue Jul 16, 2024
corrected function checkReviewComplete() considering empty fields #1650
2868578
mdvcode pushed a commit that referenced this issue Jul 16, 2024
integrated tab status updates taking into account empty fields into t…
39e731b 
…he updateTabProgressIndicatorClasses() function on contr page #1650
@jh-RLI jh-RLI mentioned this issue Jul 17, 2024
Merged
5 tasks
mdvcode pushed a commit that referenced this issue Aug 5, 2024
Integrated tab status update taking into account empty fields when lo…
aafc1e2 
…ading a page on the reviewer page #1650
mdvcode pushed a commit that referenced this issue Aug 5, 2024
update changelog #1650
1a43af1
@jh-RLI jh-RLI mentioned this issue Aug 5, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmlancien bmlancien

@jh-RLI jh-RLI

Labels
enhancement open peer review The open energy platform peer review Urgency-M urgency level: medium
Projects
Open Peer Review
Status: In Progress
Milestone
No milestone
2 participants
@bmlancien @jh-RLI