Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 562 export storage units #565

Merged
merged 9 commits into from
Sep 19, 2024
Merged

Conversation

nesnoj
Copy link
Collaborator

@nesnoj nesnoj commented Sep 17, 2024

Summary of the discussion

Allows CSV export of table storage_units

  • db.to_csv() and db.to_csv("storage_units") now export to bnetza_mastr_storage_units_raw.csv.
  • db.download("bulk", data="storage") does not include storage_units/anlagenstromspeicher anymore as I had to split "storage" in BULK_INCLUDE_TABLES_MAP to allow for CSV export. Instead, if a user wants only the storage units to be written to the DB, they need to be written separately via db.download("bulk", data="storage_units"). I assume most users write all data to the DB anyways (db.download("bulk")) which works properly.

Updated

  • Allow CSV export of table storage_units #562

Workflow checklist

Automation

Closes #562

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@nesnoj nesnoj added the 🚀 feature New feature or request label Sep 17, 2024
@nesnoj nesnoj requested a review from FlorianK13 September 17, 2024 14:13
@nesnoj nesnoj self-assigned this Sep 17, 2024
@nesnoj
Copy link
Collaborator Author

nesnoj commented Sep 17, 2024

Oh, discovered a bug in my implementation, will check..

@nesnoj nesnoj removed the request for review from FlorianK13 September 17, 2024 14:38
@nesnoj nesnoj marked this pull request as draft September 17, 2024 14:38
@nesnoj
Copy link
Collaborator Author

nesnoj commented Sep 18, 2024

Ok, good to go now

@nesnoj nesnoj requested a review from FlorianK13 September 18, 2024 11:37
@nesnoj nesnoj marked this pull request as ready for review September 18, 2024 11:37
@FlorianK13
Copy link
Member

There is the problem of tests not running. This happens when:

  • All files are pushed to a draft PR (changes to a branch with a draft PR do not trigger tests)
  • The draft PR is converted to a normal PR (changing this status does not trigger tests)

I just checked but I could find no way to run the tests manually on this PR. @nesnoj do you know this problem and a solution? The only solution that I know is to add a small change and push it to the feature branch, which will trigger the tests.

@nesnoj
Copy link
Collaborator Author

nesnoj commented Sep 18, 2024

Ok, did some minor "fix" to trigger ;)

Thanks for the explanation @FlorianK13 !
This is quite weird, maybe the trigger ready_for_review could do the trick..

BTW, the if statement in the test if: ${{ !github.event.pull_request.draft }} is not required to my mind as tests should not be triggered in draft PRs by default.

CHANGELOG.md Outdated Show resolved Hide resolved
@nesnoj nesnoj merged commit 6bc7254 into develop Sep 19, 2024
9 checks passed
@nesnoj nesnoj deleted the feature-562-export-storage-units branch September 19, 2024 15:25
This was referenced Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add storage_units to CSV export
2 participants