-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 562 export storage units #565
Conversation
Oh, discovered a bug in my implementation, will check.. |
Ok, good to go now |
There is the problem of tests not running. This happens when:
I just checked but I could find no way to run the tests manually on this PR. @nesnoj do you know this problem and a solution? The only solution that I know is to add a small change and push it to the feature branch, which will trigger the tests. |
Ok, did some minor "fix" to trigger ;) Thanks for the explanation @FlorianK13 ! BTW, the if statement in the test |
Add 'ready_for_review'
This reverts commit c678821.
Summary of the discussion
Allows CSV export of table
storage_units
db.to_csv()
anddb.to_csv("storage_units")
now export tobnetza_mastr_storage_units_raw.csv
.db.download("bulk", data="storage")
does not includestorage_units
/anlagenstromspeicher
anymore as I had to split "storage" inBULK_INCLUDE_TABLES_MAP
to allow for CSV export. Instead, if a user wants only the storage units to be written to the DB, they need to be written separately viadb.download("bulk", data="storage_units")
. I assume most users write all data to the DB anyways (db.download("bulk")
) which works properly.Updated
storage_units
#562Workflow checklist
Automation
Closes #562
PR-Assignee
Reviewer