Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bundling of locales by rollup by improving relative import #21

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Allow bundling of locales by rollup by improving relative import #21

merged 1 commit into from
Dec 13, 2024

Conversation

danyill
Copy link

@danyill danyill commented Dec 12, 2024 •
edited
Loading

Closes #20

If I say so myself, it may be some of my best work.

ca-d
ca-d approved these changes Dec 13, 2024
View reviewed changes
Copy link

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

I'd suggest we use a conventional commit message in line with our CONTRIBUTING.md document when merging this.

@ca-d ca-d merged commit 5cf26cb into OpenEnergyTools:main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-d ca-d ca-d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundling core
2 participants
@danyill @ca-d