-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: edit multiple files #22
base: main
Are you sure you want to change the base?
Conversation
This still needs the tests fixed. |
How about a toast that notifies the user if a new file is opened and the old file is renamed with a counter appended on the end. |
I've rolled this into our distribution for testing and find it to be very delightful 👍 The only additional thing which might be nice would be to copy the present file to another file and hold it in memory, but perhaps that is an anti-pattern (?). It would be nice for functionality, like "create a copy within OpenSCD and do a compare to show the changes" |
I've rolled this functionality into our distribution for some early testing and to enable testing the comparison/diffing plugin. In particular I created a snapshot plugin which takes a copy of the existing document and adds a timestamp to the name so it can be used to compare files. See here. I did this by mutating https://github.com/OpenEnergyTools/open-scd-core/blob/main/API.md#openevent Perhaps we could consider (either as part of this PR or a separate issue) have an argument as to whether the document should be opened or made the current document. |
Do you require this for SCL documents as well, or only for support documents?
|
SCL documents too please (e.g. my snapshot tool, or opening many SCL
documents without immediately changing focus).
…On Tue, 11 Feb 2025, 01:11 cad, ***@***.***> wrote:
Do you require this for SCL documents as well, or only for support
documents?
Perhaps we could consider (either as part of this PR or a separate issue)
have an argument as to whether the document should be opened or made the
current document.
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFEXX2K7N64NLAWYWAWJWD2PCJOXAVCNFSM6AAAAABTRGAC4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBXHAYDMMBUG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
No description provided.