Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read, Review, and Verify #2762

Closed
wants to merge 6 commits into from
Closed

Read, Review, and Verify #2762

wants to merge 6 commits into from

Conversation

elias-ba
Copy link
Contributor

@elias-ba elias-ba commented Dec 7, 2024

Description

This PR introduces a warning message displayed at the bottom-right corner of the AI assistant’s latest response. The warning serves as a reminder that the messages are AI-generated and encourages users to approach them critically. The message is also clickable, directing users to the AI assistant’s disclaimer for more information.

Closes #2492

Validation steps

  1. Start a conversation with the AI assistant
  2. See the little 'This response is generated by an algorithm' message at the bottom-right corner of the assistant's response
  3. Click on it to display the AI assistant's disclaimer page for more information
  4. Keep adding more messages
  5. Note that the disclaimer is only visible at the last message of the assistant.

Additional notes for the reviewer

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@elias-ba elias-ba changed the base branch from main to 2497-better-ui December 7, 2024 01:16
@elias-ba elias-ba requested a review from josephjclark December 7, 2024 01:20
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.19%. Comparing base (7385d59) to head (436f807).
Report is 130 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
+ Coverage   91.13%   91.19%   +0.06%     
==========================================
  Files         333      333              
  Lines       11844    11846       +2     
==========================================
+ Hits        10794    10803       +9     
+ Misses       1050     1043       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elias-ba elias-ba requested a review from stuartc December 7, 2024 09:01
@josephjclark
Copy link
Contributor

Thank you @elias-ba , I really like this!The behaviour and styling are great

I just need to settle on the final wording. Can we mark this as draft and I'll figure it out as oon as I can.

@josephjclark josephjclark self-assigned this Dec 9, 2024
@elias-ba elias-ba marked this pull request as draft December 9, 2024 11:32
Base automatically changed from 2497-better-ui to main December 10, 2024 07:43
@josephjclark
Copy link
Contributor

My blocker with this right now is that I want a nice little line in the UI, and a link which goes to more information.

I've been looking around in-between tasks today and I just can't find the right sort of place to send people to. Which means I might need to write it myself.

So, still thinking about this 🤔

@josephjclark
Copy link
Contributor

Closing the PR because this is way off my radar. But I want to leave the branch in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AI Assistant: Read, Review and Verify
2 participants