-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use diskcache
for caching ProtocolDAGResult
s in the Alchemiscale client
#271
base: main
Are you sure you want to change the base?
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8c2ccd9 - Browse repository at this point
Copy the full SHA 8c2ccd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 651a3fa - Browse repository at this point
Copy the full SHA 651a3faView commit details
Commits on Apr 29, 2024
-
Store raw bytes rather than pickled objects
* The default Disk used by diskcache uses pickle when storing python objects. Instead, we are now storing byte arrays. Depending on the size of the byte array, this is either stored in the SQLite3 DB or or as a separate file if it's too large (>32 kb by default). * A test has been added that checks the hits and misses when pulling PDRs using the get_transformation_results method. The in-memory LRU cache is cleared manually for accurate stats.
Configuration menu - View commit details
-
Copy full SHA for 3761de5 - Browse repository at this point
Copy the full SHA 3761de5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9a0d78 - Browse repository at this point
Copy the full SHA c9a0d78View commit details -
Enable caching for other objects
New objects supported: * Transformations * AlchemicalNetworks * ChemicalSystems * Generally anything that can be a KeyedChain
Configuration menu - View commit details
-
Copy full SHA for 471faf9 - Browse repository at this point
Copy the full SHA 471faf9View commit details -
Test cache data corruption and change test params
* With known cached results, corrupt the values and make sure the user is warned that there was a problem with deserialization and that a new result will be downloaded. * Lowered the cache size limit for tests to avoid running out of space
Configuration menu - View commit details
-
Copy full SHA for 18c6248 - Browse repository at this point
Copy the full SHA 18c6248View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 383e473 - Browse repository at this point
Copy the full SHA 383e473View commit details -
Clean up of interface/client/conftest.py
* Removed unsused imports
Configuration menu - View commit details
-
Copy full SHA for 42366c8 - Browse repository at this point
Copy the full SHA 42366c8View commit details -
Updated cache parameter handling in AlchemiscaleBaseClient
The AlchemiscaleBaseClient now determines the cache directory when one is not specified directly (i.e. a None is provided to the AlchemiscaleBaseClient constructor). When a path to this directory is provided, it must be a string or pathlib.Path object. The logic for this operation lies in the `AlchemiscaleBaseClient._determine_cache_dir` method, which can raise a TypeError on invalid input. The `cache_size_limit` is now verified within the constructor to be >= 0. If it is not, then a ValueError is raised. New tests have been added for the above changes: * Negative cache_size_limit: checks for constructor-raised ValueError with a meaningful message. * cache_directory is None: checks output of the underlying _determine_cache_dir method with and without the XDG_CACHE_HOME environment variable. If we test it with the client constructor, the directory is made automatically, which we don't want in the tests as it may touch real data. * cache_directory is not None, str, or Path: Check that the constructor raises a TypeError with a meaningful message.
Configuration menu - View commit details
-
Copy full SHA for 3975cd4 - Browse repository at this point
Copy the full SHA 3975cd4View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4049373 - Browse repository at this point
Copy the full SHA 4049373View commit details