Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: starting implementing classification metrics. #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RiesBen
Copy link

@RiesBen RiesBen commented May 16, 2024

Description

Here we would like to add classifications scores and the score inspired by Chris Bailey at the Alchemistry Talk 2024

@matthewtwarren: this might be interesting for you :)

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Implement simple classification score
  • Advance to the Iterative score

Status

  • Planning
  • Testing
  • Ready to go

@pep8speaks
Copy link

pep8speaks commented May 16, 2024

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 10:106: E231 missing whitespace after ':'
Line 10:112: E252 missing whitespace around parameter equals
Line 10:120: E501 line too long (146 > 119 characters)
Line 10:134: E231 missing whitespace after ':'
Line 10:140: E252 missing whitespace around parameter equals
Line 10:141: E252 missing whitespace around parameter equals
Line 12:120: E501 line too long (120 > 119 characters)
Line 24:18: E201 whitespace after '['
Line 24:38: E202 whitespace before ']'
Line 29:18: E201 whitespace after '['
Line 29:38: E202 whitespace before ']'
Line 50:25: E225 missing whitespace around operator
Line 69:42: E231 missing whitespace after ':'
Line 70:38: E231 missing whitespace after ':'
Line 70:42: E252 missing whitespace around parameter equals
Line 70:43: E252 missing whitespace around parameter equals
Line 70:57: E231 missing whitespace after ':'
Line 70:61: E252 missing whitespace around parameter equals
Line 70:62: E252 missing whitespace around parameter equals
Line 70:86: E231 missing whitespace after ':'
Line 70:92: E252 missing whitespace around parameter equals
Line 70:93: E252 missing whitespace around parameter equals
Line 70:98: E225 missing whitespace around operator
Line 95:120: E501 line too long (139 > 119 characters)
Line 114:23: E231 missing whitespace after ':'
Line 114:94: E231 missing whitespace after ':'
Line 114:100: E252 missing whitespace around parameter equals
Line 114:101: E252 missing whitespace around parameter equals
Line 114:105: E225 missing whitespace around operator
Line 122:22: W292 no newline at end of file

Comment last updated at 2024-05-16 13:58:47 UTC

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 82.24%. Comparing base (c140fea) to head (ddaac93).

Additional details and impacted files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants