Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in a little more documentation #33

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fill in a little more documentation #33

merged 1 commit into from
Oct 5, 2023

Conversation

dwhswenson
Copy link
Member

A few spots that seemed empty once I was actually looking at the API docs on RTD.

A few spots that seemed empty once I was actually looking at the API
docs on RTD.
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f5862a2) 91.44% compared to head (520525e) 91.44%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files           7        7           
  Lines         526      526           
=======================================
  Hits          481      481           
  Misses         45       45           
Files Coverage Δ
exorcist/taskdb.py 97.48% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwhswenson
Copy link
Member Author

Looks like we're triggering PR builds, but not reporting that back as a GitHub status check. I had some trouble with permissions between the OpenFE org and my RTD account, and ended up setting up webhooks manually.

@mikemhenry (or possibly @Yoshanuikabundi) : Do you know the magic to correctly set up PR builds with status checks? You should both have invites to the Exorcist RTD.

@dwhswenson
Copy link
Member Author

close/open cycle to see if this works now that @Yoshanuikabundi did some magic to the webhook

@dwhswenson dwhswenson closed this Oct 5, 2023
@dwhswenson dwhswenson reopened this Oct 5, 2023
@dwhswenson
Copy link
Member Author

I'm gonna say that adding 3 docstrings doesn't require a review, and just merge this now. Main purpose of this PR was actually to check RTD/GitHub integration worked (which it now does!)

@dwhswenson dwhswenson merged commit a2854b0 into main Oct 5, 2023
8 checks passed
@dwhswenson dwhswenson deleted the more-docs branch October 5, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant