Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test openmm 8.2 again #1144

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Test openmm 8.2 again #1144

wants to merge 7 commits into from

Conversation

mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

@mikemhenry mikemhenry marked this pull request as draft February 19, 2025 15:40
@atravitz atravitz changed the title Tes openmm 8.2 again Test openmm 8.2 again Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (829ce37) to head (a9f88a8).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
- Coverage   93.53%   91.89%   -1.64%     
==========================================
  Files         142      142              
  Lines       10635    10635              
==========================================
- Hits         9947     9773     -174     
- Misses        688      862     +174     
Flag Coverage Δ
fast-tests 91.89% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Contributor Author

Testing this using the GPU runner but I think the action needs updating

@mikemhenry
Copy link
Contributor Author

Looks like we are seeing the same error:

cls = <class 'mdtraj.core.topology.Bond'>, atom1 = ACE0-C, atom2 = ACE0-CH3
type = None, order = Single

    def __new__(cls, atom1, atom2, type=None, order=None):
        """Construct a new Bond.  You should call add_bond()
        on the Topology instead of calling this directly.
    
        Must use __new__ constructor since this is an immutable class
        """
        bond = super().__new__(cls, atom1, atom2)
        assert isinstance(type, Singleton) or type is None, "Type must be None or a Singleton"
>       assert order is None or 1 <= order <= 3, "Order must be int between 1 to 3 or None"
E       TypeError: '<=' not supported between instances of 'int' and 'Single'

So something changed with the way openmm does the bond data structure

@mikemhenry
Copy link
Contributor Author

Going to test installing mdtraj from main

Copy link

No API break detected ✅

@mikemhenry
Copy link
Contributor Author

ah i need to be careful how i install mdtraj from main since the package install test might be an isolated env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant