fix: When lines reverse on themselves, mitering could be wrong #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a line reversed direction exactly, mitering logic could render only half the pixels that should have been rendered. In general, when lines nearly reverse on themselves, mitering is tricky. This add some thresholds, below which the lines aren't mitered but are just rendered. For opaque lines, this is a strict improvement, though some joints may no longer show rounded or truncated miters. For semi-transparent lines, this is in general an improvement, but there can be cases where they appear double rendered instead of joined. The behavior is still deemed an improvement, as they should never have only have half the pixels rendered.
|
🎉 This PR is included in version 1.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a line reversed direction exactly, mitering logic could render only half the pixels that should have been rendered. In general, when lines nearly reverse on themselves, mitering is tricky. This add some thresholds, below which the lines aren't mitered but are just rendered. For opaque lines, this is a strict improvement, though some joints may no longer show rounded or truncated miters. For semi-transparent lines, this is in general an improvement, but there can be cases where they appear double rendered instead of joined. The behavior is still deemed an improvement, as they should never have only have half the pixels rendered.