failing test for customer use case (#914) (#917)

Fixes issue when a Class of X contains a field with a List<X> then WireMarshaller recursively attempts to resolve X. closes #915

Co-authored-by: Jerry Shea <[email protected]>

src/main/java/net/openhft/chronicle/wire/WireMarshaller.java

@@ -1563,6 +1563,8 @@ else if (type == Set.class)
             componentType = extractClass(computeActualTypeArguments(Collection.class, field)[0]);
             if (componentType != Object.class) {
                 isLeaf = !Throwable.class.isAssignableFrom(componentType)
+                        // Don't recurse into the same class
+                        && !componentType.equals(field.getDeclaringClass())
                         && WIRE_MARSHALLER_CL.get(componentType).isLeaf;
             }
 

src/test/java/net/openhft/chronicle/wire/recursive/Base.java

@@ -0,0 +1,15 @@
+package net.openhft.chronicle.wire.recursive;
+
+import net.openhft.chronicle.wire.AbstractEventCfg;
+
+public class Base extends AbstractEventCfg<Base> {
+    private final String name;
+
+    public  Base(String name) {
+         this.name = name;
+    }
+
+    public String name() {
+        return name;
+    }
+}

src/test/java/net/openhft/chronicle/wire/recursive/RecursiveTest.java

@@ -0,0 +1,42 @@
+package net.openhft.chronicle.wire.recursive;
+
+import net.openhft.chronicle.wire.WireMarshaller;
+import org.junit.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+/**
+ * Test for recursion in the marshaller and fields. WIRE_MARSHALLER_CL.get should not recurse while
+ * looking up fields of the class. At time of writing this occurs when checking if the component class
+ * of a subfield is a leaf and is only a problem when the component class is the same as the parent class.
+ */
+public class RecursiveTest {
+
+    @Test
+    public void referToBaseClass() {
+        test(new ReferToBaseClass("hello"), new ReferToBaseClass(null));
+    }
+
+    @Test
+    public void referToSameClass() {
+        test(new ReferToSameClass("test"), new ReferToSameClass(null));
+    }
+
+    @Test
+    public void marshallerReferToSameClass() {
+        WireMarshaller<?> marshaller= WireMarshaller.WIRE_MARSHALLER_CL.get(ReferToSameClass.class);
+        assertNotNull(marshaller);
+    }
+
+    @Test
+    public void marshallerReferToBaseClass() {
+        WireMarshaller<?> marshaller = WireMarshaller.WIRE_MARSHALLER_CL.get(ReferToBaseClass.class);
+        assertNotNull(marshaller);
+    }
+
+    private void test(Base from, Base to) {
+        from.copyTo(to);
+        assertEquals(from.name(), to.name());
+    }
+}

src/test/java/net/openhft/chronicle/wire/recursive/ReferToBaseClass.java

@@ -0,0 +1,16 @@
+package net.openhft.chronicle.wire.recursive;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class ReferToBaseClass extends ReferToSameClass {
+    private final List<ReferToSameClass> list = new ArrayList<>();
+
+    public ReferToBaseClass(String name) {
+        super(name);
+    }
+
+    public List<ReferToSameClass> list() {
+        return list;
+    }
+}

src/test/java/net/openhft/chronicle/wire/recursive/ReferToSameClass.java

@@ -0,0 +1,16 @@
+package net.openhft.chronicle.wire.recursive;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class ReferToSameClass extends Base {
+    private final List<ReferToSameClass> list = new ArrayList<>();
+
+    public ReferToSameClass(String name) {
+        super(name);
+    }
+
+    public List<ReferToSameClass> list() {
+        return list;
+    }
+}