Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid producing garbage in escaping quotes #417

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Avoid producing garbage in escaping quotes #417

merged 1 commit into from
Mar 23, 2022

Conversation

alamar
Copy link
Contributor

@alamar alamar commented Mar 18, 2022

fixes #377

@alamar alamar requested review from peter-lawrey and glukos March 18, 2022 11:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 6 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@glukos
Copy link
Contributor

glukos commented Mar 22, 2022

Another question is why we need to store stop char testers by WeakReference, it also can cause allocations. But of a smaller magintude - in case the code is hot.

@alamar
Copy link
Contributor Author

alamar commented Mar 23, 2022

@glukos I took care of it by filing OpenHFT/Chronicle-Core#361

@alamar alamar merged commit 308f2dd into develop Mar 23, 2022
@alamar alamar deleted the Issue377 branch March 23, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glukos glukos glukos approved these changes

@peter-lawrey peter-lawrey Awaiting requested review from peter-lawrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamar @glukos