Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimising the writing and reading of JSON #975

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Optimising the writing and reading of JSON #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 101 additions & 32 deletions microbenchmarks/src/main/java/net/openhft/chronicle/wire/benchmarks/ComparisonMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,16 @@
package net.openhft.chronicle.wire.benchmarks;

import com.alibaba.fastjson.JSON;
import com.alibaba.fastjson.JSONException;
import com.alibaba.fastjson.serializer.SerializeConfig;
import com.alibaba.fastjson2.JSONWriter;
import com.alibaba.fastjson2.writer.ObjectWriter;
import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.core.JsonParser;
import net.minidev.json.JSONObject;
import net.minidev.json.JSONStyle;
import net.minidev.json.parser.JSONParser;
import net.openhft.affinity.Affinity;
import net.openhft.affinity.AffinityLock;
import net.openhft.chronicle.bytes.Bytes;
import net.openhft.chronicle.core.Jvm;
Expand Down Expand Up @@ -49,20 +54,27 @@
import java.nio.ByteBuffer;
import java.util.concurrent.TimeUnit;

/* on a Ryzen 5950X, with 8 threads
Benchmark Mode Cnt Score Error Units
ComparisonMain.fastjson thrpt 33 10986645.275 ± 1033839.257 ops/s
ComparisonMain.jacksonWithCBytes thrpt 33 11644821.957 ± 186579.126 ops/s
ComparisonMain.jsonBytes thrpt 33 12630238.718 ± 178770.580 ops/s
ComparisonMain.jsonWire thrpt 33 3750653.689 ± 256018.536 ops/s
*/
/**
* Compare JSON writing/parsing
*/
@State(Scope.Thread)
public class ComparisonMain {
final Yaml yaml;
final ExternalizableData data = new ExternalizableData(123, 1234567890L, 1234.5, true, "Hello World!", Side.Sell);
private final ByteBuffer allocate = ByteBuffer.allocate(64);
private final UnsafeBuffer buffer = new UnsafeBuffer(allocate);
final ExternalizableData data = new ExternalizableData(1234.5678, true, "Hello World!", Side.Sell, 123, 1234567890L);
//private final ByteBuffer allocate = ByteBuffer.allocate(64);
//private final UnsafeBuffer buffer = new UnsafeBuffer(allocate);
ExternalizableData data2 = new ExternalizableData();
String s;
StringBuilder sb = new StringBuilder();
JSONParser jsonParser = new JSONParser(JSONParser.MODE_JSON_SIMPLE);
// {"smallInt":123,"longInt":1234567890,"price":1234.0,"flag":true,"text":"Hello World","side":"Sell"}
// {"smallInt":123,"longInt":1234567890,"price":1234.5678,"flag":true,"text":"Hello World","side":"Sell"}
com.fasterxml.jackson.core.JsonFactory jsonFactory = new com.fasterxml.jackson.core.JsonFactory(); // or, for data binding, org.codehaus.jackson.mapper.MappingJsonFactory
UnsafeBuffer directBuffer = new UnsafeBuffer(ByteBuffer.allocateDirect(128));
Bytes<?> bytes = Bytes.allocateDirect(512).unchecked(true);
Expand All @@ -75,6 +87,7 @@ public class ComparisonMain {
JsonParser jp;
JsonParser textJP;
private byte[] buf;
private AffinityLock affinityLock;

public ComparisonMain() {
DumperOptions options = new DumperOptions();
Expand Down Expand Up @@ -120,27 +133,42 @@ public static void main(String... args) throws Exception {
}
}
} else {
try (AffinityLock affinityLock = AffinityLock.acquireLock(Jvm.getProperty("affinity", "any"))) {
int time = Jvm.getBoolean("longTest") ? 30 : 2;
System.out.println("measurementTime: " + time + " secs");
Options opt = new OptionsBuilder()
.include(ComparisonMain.class.getSimpleName())
.warmupIterations(5)
.measurementIterations(5)
.threads(2)
.forks(1) // use only one fork with affinity
.mode(Mode.SampleTime)
.warmupTime(TimeValue.seconds(1))
.measurementTime(TimeValue.seconds(time))
.timeUnit(TimeUnit.NANOSECONDS)
.build();

new Runner(opt).run();
}
int time = Jvm.getBoolean("longTest") ? 30 : 2;
System.out.println("measurementTime: " + time + " secs");
String[] jvmArgs = {
"--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED",
"--add-exports=java.base/jdk.internal.ref=ALL-UNNAMED",
"--add-exports=java.base/jdk.internal.util=ALL-UNNAMED",
"--add-exports=java.base/sun.nio.ch=ALL-UNNAMED",
"--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED",
"--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED",
"--add-exports=jdk.unsupported/sun.misc=ALL-UNNAMED",
"--add-opens=java.base/java.io=ALL-UNNAMED",
"--add-opens=java.base/java.lang=ALL-UNNAMED",
"--add-opens=java.base/java.lang.reflect=ALL-UNNAMED",
"--add-opens=java.base/java.util=ALL-UNNAMED",
"--add-opens=jdk.compiler/com.sun.tools.javac=ALL-UNNAMED"};
if (!Jvm.isJava9Plus())
jvmArgs = new String[0];

Options opt = new OptionsBuilder()
.include(ComparisonMain.class.getSimpleName())
.jvmArgsAppend(jvmArgs)
.warmupIterations(3)
.measurementIterations(3)
.threads(8)
.forks(11)
.mode(Mode.Throughput)
.warmupTime(TimeValue.seconds(1))
.measurementTime(TimeValue.seconds(time))
.timeUnit(TimeUnit.SECONDS)
.build();

new Runner(opt).run();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why fork?

}
}

@Benchmark
// @Benchmark
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove these attrs?

public Data snakeYaml() {
s = yaml.dumpAsMap(data);
Data data = yaml.load(s);
Expand Down Expand Up @@ -169,7 +197,7 @@ public void jsonSmartCompact() throws net.minidev.json.parser.ParseException {
data.readFrom(jsonObject);
}

@Benchmark
// @Benchmark
public ExternalizableData jackson() throws IOException {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
JsonGenerator generator = jsonFactory.createGenerator(baos);
Expand All @@ -184,17 +212,18 @@ public ExternalizableData jackson() throws IOException {

@Benchmark
public ExternalizableData jacksonWithCBytes() throws IOException {
if (affinityLock == null)
affinityLock = Affinity.acquireLock();
bytes.clear();
generator = jsonFactory.createGenerator(outputStream);
data.writeTo(generator);
generator.flush();

jp.clearCurrentToken();
data2.readFrom(jp);
return data2;
}

@Benchmark
// @Benchmark
public ExternalizableData jacksonWithTextCBytes() throws IOException {
bytes.clear();
generator = jsonFactory.createGenerator(writer);
Expand All @@ -206,7 +235,7 @@ public ExternalizableData jacksonWithTextCBytes() throws IOException {
return data2;
}

@Benchmark
// @Benchmark
public Object externalizable() throws IOException, ClassNotFoundException {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
ObjectOutputStream oos = new ObjectOutputStream(baos);
Expand All @@ -219,7 +248,7 @@ public Object externalizable() throws IOException, ClassNotFoundException {
}
}

@Benchmark
// @Benchmark
public Object externalizableWithCBytes() throws IOException, ClassNotFoundException {
bytes.clear();
ObjectOutputStream oos = new ObjectOutputStream(outputStream);
Expand All @@ -232,6 +261,9 @@ public Object externalizableWithCBytes() throws IOException, ClassNotFoundExcept

@Benchmark
public Object jsonWire() {
if (affinityLock == null)
affinityLock = Affinity.acquireLock();

jsonWire.reset();
jsonWire.getValueOut().marshallable((WriteMarshallable) data);
// below is faster than jsonWire.getValueIn().marshallable((ReadMarshallable) data2) as it does not read length first
Expand All @@ -240,11 +272,48 @@ public Object jsonWire() {
}

@Benchmark
public Object fastjson() {
public Object jsonBytes() {
if (affinityLock == null)
affinityLock = Affinity.acquireLock();
bytes.clear();
// TODO: JSONWriter
byte[] ba = JSON.toJSONBytes(data);
bytes.write(ba);
return JSON.parseObject(ba, ExternalizableData.class);
data.writeMarshallable(bytes);
data2.readMarshallable(bytes);
return data2;
}

JSONWriter.Context context = JSON.createWriteContext(SerializeConfig.global, JSON.DEFAULT_GENERATE_FEATURE);

@Benchmark
public Object fastjson() {
if (affinityLock == null)
affinityLock = Affinity.acquireLock();

try (JSONWriter writer1 = JSONWriter.ofUTF8(context)) {
writer1.setRootObject(data);
Class<?> valueClass = ((Object) data).getClass();
ObjectWriter objectWriter = context.getObjectWriter(valueClass, valueClass);
objectWriter.write(writer1, data, null, null, 0);

byte[] result = writer1.getBytes();

return JSON.parseObject(result, ExternalizableData.class);
} catch (com.alibaba.fastjson2.JSONException ex) {
Throwable cause = ex.getCause() != null ? ex.getCause() : ex;
throw new JSONException("toJSONBytes error", cause);
} catch (RuntimeException ex) {
throw new JSONException("toJSONBytes error", ex);
}
}

static class Profile {
static volatile Object bh;

public static void main(String[] args) {
ComparisonMain comparisonMain = new ComparisonMain();
long start = System.currentTimeMillis();
do {
bh = comparisonMain.jsonBytes();
} while (System.currentTimeMillis() < start + 30_000);
}
}
}
91 changes: 76 additions & 15 deletions microbenchmarks/src/main/java/net/openhft/chronicle/wire/benchmarks/ExternalizableData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.core.JsonToken;
import net.minidev.json.JSONObject;
import net.openhft.chronicle.bytes.BytesIn;
import net.openhft.chronicle.bytes.*;
import net.openhft.chronicle.bytes.internal.BytesInternal;
import net.openhft.chronicle.core.io.IORuntimeException;
import net.openhft.chronicle.core.io.InvalidMarshallableException;
import net.openhft.chronicle.wire.SelfDescribingMarshallable;
Expand All @@ -31,28 +32,42 @@
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
import java.nio.BufferUnderflowException;

public class ExternalizableData extends SelfDescribingMarshallable implements Externalizable {
int smallInt = 0;
long longInt = 0;
// {"smallInt":123,"longInt":1234567890,"price":1234.0,"flag":true,"text":"Hello World","side":"Sell"}

static final Bytes<Void> PRICE = Bytes.fromDirect("{\"price\":");
static final Bytes<Void> FLAG = Bytes.fromDirect(",\"flag\":");
static final Bytes<Void> TEXT = Bytes.fromDirect("\"text\":\"");
static final Bytes<Void> SIDE = Bytes.fromDirect("\",\"side\":\"");
static final Bytes<Void> SMALL_INT = Bytes.fromDirect("\",\"smallInt\":");
static final Bytes<Void> LONG_INT = Bytes.fromDirect(",\"longInt\":");
static final Bytes<Void> END = Bytes.fromDirect("}");
static final Bytes<Void> TRUE = Bytes.fromDirect("true");
static final Bytes<Void> FALSE = Bytes.fromDirect("false");

double price = 0;
boolean flag = false;
String text;
Bytes<?> textBytes;
Side side;
int smallInt = 0;
long longInt = 0;

public ExternalizableData(int smallInt, long longInt, double price, boolean flag, String text, Side side) {
this.smallInt = smallInt;
this.longInt = longInt;
public ExternalizableData(double price, boolean flag, String text, Side side, int smallInt, long longInt) {
this.price = price;
this.flag = flag;
this.side = side;
this.text = text;
textBytes = Bytes.from(text);
this.side = side;
this.smallInt = smallInt;
this.longInt = longInt;
}

public ExternalizableData() {

textBytes = Bytes.allocateElasticOnHeap(128).unchecked(true);
}

public int getSmallInt() {
return smallInt;
}
Expand Down Expand Up @@ -161,27 +176,27 @@ public void writeTo(JsonGenerator generator) throws IOException {
@Override
public void writeExternal(ObjectOutput out) throws IOException {
out.writeDouble(price);
out.writeLong(longInt);
out.writeInt(smallInt);
out.writeBoolean(flag);
out.writeObject(side);
out.writeObject(getText());
out.writeObject(side);
out.writeInt(smallInt);
out.writeLong(longInt);
}

@Override
public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
setPrice(in.readDouble());
setLongInt(in.readLong());
setSmallInt(in.readInt());
setFlag(in.readBoolean());
setText((String) in.readObject());
Object s = in.readObject();
if (s instanceof Side)
setSide((Side) s);
else if (s instanceof String)
setSide(Side.valueOf((String) s));
else
throw new IllegalStateException();
setText((String) in.readObject());
setSmallInt(in.readInt());
setLongInt(in.readLong());
}

@Override
Expand All @@ -203,4 +218,50 @@ public void readMarshallable(WireIn wire) throws IORuntimeException, InvalidMars
smallInt = wire.read("smallInt").readInt();
longInt = wire.read("longInt").readLong();
}

@Override
public void writeMarshallable(BytesOut<?> bytes) throws InvalidMarshallableException {
appendBytes(bytes, PRICE);
bytes.append(price);
appendBytes(bytes, FLAG);
appendBytes(bytes, flag ? TRUE : FALSE);
appendBytes(bytes, TEXT);
appendBytes(bytes, textBytes);
appendBytes(bytes, SIDE);
appendBytes(bytes, side.bs);
appendBytes(bytes, SMALL_INT);
bytes.append(smallInt);
appendBytes(bytes, LONG_INT);
bytes.append(longInt);
appendBytes(bytes, END);
}

private static void appendBytes(BytesOut<?> bytes, BytesStore<?, ?> bytesAdded) {
BytesInternal.writeFully(bytesAdded, 0, bytesAdded.readLimit(), bytes);
}

@Override
public void readMarshallable(BytesIn<?> bytes) throws IORuntimeException, InvalidMarshallableException {
expectUtf8(bytes, PRICE, 0);
price = bytes.parseDouble();
expectUtf8(bytes, FLAG, -1);
flag = Boolean.TRUE.equals(bytes.parseBoolean());
expectUtf8(bytes, TEXT, -1);
bytes.parseUtf8(textBytes, StopCharTesters.QUOTES);
expectUtf8(bytes, SIDE, -1);
side = Side.valueOf(bytes.parse8bit(StopCharTesters.QUOTES));
expectUtf8(bytes, SMALL_INT, -1);
smallInt = bytes.parseInt();
expectUtf8(bytes, LONG_INT, -1);
longInt = bytes.parseLong();
expectUtf8(bytes, END, 0);
}

private void expectUtf8(BytesIn<?> bytesIn, Bytes<Void> text, int readSkip) {
Bytes<?> bytes = (Bytes<?>) bytesIn;
bytes.readSkip(readSkip);
if (!bytes.startsWith(text))
throw new IORuntimeException("Expected " + text + " but got " + bytes);
bytes.readSkip(text.length());
}
}
6 changes: 5 additions & 1 deletion microbenchmarks/src/main/java/net/openhft/chronicle/wire/benchmarks/Side.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@

package net.openhft.chronicle.wire.benchmarks;

import net.openhft.chronicle.bytes.BytesStore;

public enum Side {
Buy, Sell
Buy, Sell;

final BytesStore<?,?> bs = BytesStore.from(this.name());
}