Centralized branding #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson9583
reviewed
Apr 8, 2025
kpalang
force-pushed
the
feature/centralized-branding
branch
from
9756a2c to
788dc0b
Compare
jonbartels
requested changes
Apr 8, 2025
server/src/com/mirth/connect/server/servlets/WebStartServlet.java
Outdated
Show resolved
Hide resolved
jonbartels
previously approved these changes
Apr 11, 2025
kryskool
reviewed
Apr 12, 2025
jonbartels
previously approved these changes
Apr 14, 2025
tonygermano
reviewed
Apr 18, 2025
kpalang
force-pushed
the
feature/centralized-branding
branch
from
8de9a03 to
87c390b
Compare
Signed-off-by: Kaur Palang <[email protected]>
Signed-off-by: Kaur Palang <[email protected]>
Signed-off-by: Kaur Palang <[email protected]>
kpalang
force-pushed
the
feature/centralized-branding
branch
from
87c390b to
39e72c9
Compare
Signed-off-by: Kaur Palang <[email protected]>
kpalang
force-pushed
the
feature/centralized-branding
branch
from
39e72c9 to
c416225
Compare
jonbartels
requested changes
May 1, 2025
There was a problem hiding this comment.
Update the comments in BrandingConstants.
Someone like a graphic designer or CEO should be able to look at this file and know what to update so that OIE becomes their company tool.
The comments in BrandingConstants should explain, in tiny words, what to do to a non-developer to brand the app
| // The URL that is opened when clicking "Visit + PRODUCT_NAME" button in Administrator | ||
| public static final String HOMEPAGE_URL = "https://openintegrationengine.org/"; | ||
|
|
||
| // Icons |
There was a problem hiding this comment.
What size and format is tolerated for the favicon?
Where is it displayed?
NicoPiel
reviewed
May 1, 2025
| @@ -349,7 +350,7 @@ protected Document getExtensionJnlp(String extensionPath) throws Exception { | |||
| informationElement.appendChild(titleElement); | |||
|
|
|||
| Element vendorElement = document.createElement("vendor"); | |||
| vendorElement.setTextContent("NextGen Healthcare"); | |||
| vendorElement.setTextContent(BrandingConstants.PRODUCT_NAME); | |||
There was a problem hiding this comment.
There should be a difference between product and vendor name.
There was a problem hiding this comment.
@NicoPiel I think we all had discussed this, good catch.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gathers together all places where branding is used, to make it easier to build white-label spins of OpenIntegrationEngine.
Not ready to merge.
Closes #4