Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test one of for persist connection on error conditons #30732

Open
wants to merge 4 commits into
base: integration
Choose a base branch
from

Conversation

mrsaldana
Copy link
Member

@mrsaldana mrsaldana commented Feb 6, 2025

Sample configuration:

<httpEndpoint host="*" httpPort="9080" httpsPort="9443" id="HTTPS">
   <httpOptions persistOnError="true"/>
</httpEndpoint>

@mrsaldana mrsaldana force-pushed the persistNotClosedOneOf branch from 2a7baac to deb93d0 Compare February 6, 2025 14:49
@mrsaldana mrsaldana force-pushed the persistNotClosedOneOf branch from deb93d0 to 8514489 Compare February 6, 2025 14:55
@mrsaldana
Copy link
Member Author

mrsaldana commented Feb 6, 2025

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Feb 6, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 3 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@isaacrivriv
Copy link
Member

@isaacrivriv
Copy link
Member

isaacrivriv commented Feb 6, 2025

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Feb 6, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 3 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

LibbyBot commented Feb 6, 2025

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_jldHAOS2Ee-8r5tnb1tr6Q

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Feb 6, 2025

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_cNWRMOTbEe-8r5tnb1tr6Q

Target locations of links might be accessible only to IBM employees.

@mrsaldana mrsaldana force-pushed the persistNotClosedOneOf branch 2 times, most recently from 02ee71f to 3782221 Compare February 7, 2025 14:48
@mrsaldana mrsaldana force-pushed the persistNotClosedOneOf branch from 3782221 to ee202c1 Compare February 7, 2025 14:52
@seshadhri-aswath
Copy link
Contributor

seshadhri-aswath commented Feb 10, 2025

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_cZ7BsOdZEe-iaLY-3Iflhw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 5 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/ Please review.

    • dev/com.ibm.ws.transport.http/resources/OSGI-INF/l10n/metatype.properties

@seshadhri-aswath
Copy link
Contributor

seshadhri-aswath commented Feb 10, 2025

@seshadhri-aswath
Copy link
Contributor

seshadhri-aswath commented Feb 10, 2025

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 5 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/ Please review.

    • dev/com.ibm.ws.transport.http/resources/OSGI-INF/l10n/metatype.properties

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_6cZbYOecEe-iabY-3Iflhw

Target locations of links might be accessible only to IBM employees.

@volosied volosied mentioned this pull request Feb 10, 2025
3 tasks
@seshadhri-aswath seshadhri-aswath linked an issue Feb 11, 2025 that may be closed by this pull request
@seshadhri-aswath seshadhri-aswath marked this pull request as ready for review February 12, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liberty Closes the Persistent Connection in error state
4 participants