Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServiceCaller for ArtifactContainerFactory #30737

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Use ServiceCaller for ArtifactContainerFactory #30737

merged 1 commit into from
Feb 14, 2025

Conversation

tjwatson
Copy link
Member

@tjwatson tjwatson commented Feb 6, 2025

@tjwatson
Copy link
Member Author

tjwatson commented Feb 6, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Feb 6, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

LibbyBot commented Feb 7, 2025

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_M9-ZoOT_Ee-8r5tnb1tr6Q

Target locations of links might be accessible only to IBM employees.

@tjwatson tjwatson force-pushed the cleanupContainerClassLoader branch from 5d09aba to 759c79a Compare February 7, 2025 14:45
@tjwatson
Copy link
Member Author

tjwatson commented Feb 7, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@tjwatson tjwatson requested a review from jhanders34 February 7, 2025 14:47
@LibbyBot
Copy link

LibbyBot commented Feb 7, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

LibbyBot commented Feb 7, 2025

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_hORY4eWVEe-8r5tnb1tr6Q

Target locations of links might be accessible only to IBM employees.

@dazavala dazavala self-requested a review February 12, 2025 13:05
dazavala
dazavala previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@dazavala dazavala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left one comment for your consideration.

dev/com.ibm.ws.classloading/src/com/ibm/ws/classloading/internal/ContainerClassLoader.java Outdated Show resolved Hide resolved
@tjwatson tjwatson force-pushed the cleanupContainerClassLoader branch from 759c79a to 96cdb9e Compare February 12, 2025 15:07
dazavala
dazavala approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@dazavala dazavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fyi, you did not log the IllegalStateException in the corresponding debug output.

dev/com.ibm.ws.classloading/src/com/ibm/ws/classloading/internal/ContainerClassLoader.java Show resolved Hide resolved
@dazavala
Copy link
Contributor

dazavala commented Feb 12, 2025 •
edited by LibbyBot
Loading

#build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_e80Z4OmWEe-iabY-3Iflhw

Target locations of links might be accessible only to IBM employees.

@tjwatson tjwatson merged commit a70589e into OpenLiberty:integration Feb 14, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazavala dazavala dazavala approved these changes

@jhanders34 jhanders34 Awaiting requested review from jhanders34

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjwatson @LibbyBot @dazavala