Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving the macro to copy FIPS keys #30749

Merged
merged 13 commits into from
Feb 18, 2025
Merged

Moving the macro to copy FIPS keys #30749

merged 13 commits into from
Feb 18, 2025

Conversation

mshah0722
Copy link
Contributor

Moving macro to copy LTPA keys from security.fat.common into fat.gradle file.
Also switch to use bnd property.

@mshah0722 mshah0722 self-assigned this Feb 10, 2025
@mshah0722 mshah0722 linked an issue Feb 10, 2025 that may be closed by this pull request
Fix bootstrap.properties files with extra :\ in the end #30622
Closed
@mshah0722
Copy link
Contributor Author

mshah0722 commented Feb 10, 2025 •
edited by LibbyBot
Loading

#libby
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 95 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 95 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@mshah0722
Copy link
Contributor Author

#libby
!build

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 95 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 95 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@mshah0722
Copy link
Contributor Author

mshah0722 commented Feb 12, 2025 •
edited by LibbyBot
Loading

#libby
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 95 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 95 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@mshah0722
Copy link
Contributor Author

mshah0722 commented Feb 13, 2025 •
edited by LibbyBot
Loading

#libby
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 95 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 95 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@mshah0722
Copy link
Contributor Author

mshah0722 commented Feb 14, 2025 •
edited by LibbyBot
Loading

#libby
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 101 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 101 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@mshah0722
Copy link
Contributor Author

mshah0722 commented Feb 14, 2025 •
edited by LibbyBot
Loading

#libby
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 102 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 102 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@mshah0722
Copy link
Contributor Author

mshah0722 commented Feb 17, 2025 •
edited by LibbyBot
Loading

#libby
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 102 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 102 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@mshah0722 mshah0722 merged commit 6f694af into OpenLiberty:integration Feb 18, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zech-Hein Zech-Hein Zech-Hein approved these changes

@arkarkala arkarkala Awaiting requested review from arkarkala

@utle utle Awaiting requested review from utle

@jacobwdv jacobwdv Awaiting requested review from jacobwdv

@jhanders34 jhanders34 Awaiting requested review from jhanders34

Assignees

@mshah0722 mshah0722

Labels
CLA Signed team:Core Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bootstrap.properties files with extra :\ in the end
4 participants
@mshah0722 @LibbyBot @Zech-Hein @jacobwdv