Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashing algorithms when FIPs 140-3 is enabled #30769

Conversation

adriankalafut
Copy link
Contributor

@adriankalafut adriankalafut commented Feb 11, 2025

Applies SHA-512 hash encryption default when FIPS 140-3 is enabled.

@adriankalafut adriankalafut self-assigned this Feb 11, 2025
@adriankalafut adriankalafut force-pushed the add-fips-to-hash-function-2025-0210 branch 3 times, most recently from 2d1f332 to 2c3a027 Compare February 11, 2025 19:54
@adriankalafut
Copy link
Contributor Author

adriankalafut commented Feb 11, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@adriankalafut adriankalafut force-pushed the add-fips-to-hash-function-2025-0210 branch from 2c3a027 to a90f397 Compare February 12, 2025 15:38
@adriankalafut
Copy link
Contributor Author

adriankalafut commented Feb 12, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@adriankalafut adriankalafut force-pushed the add-fips-to-hash-function-2025-0210 branch from e957c3b to 0b99f96 Compare February 12, 2025 15:46
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@adriankalafut
Copy link
Contributor Author

adriankalafut commented Feb 12, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@adriankalafut
Copy link
Contributor Author

!build

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@adriankalafut
Copy link
Contributor Author

adriankalafut commented Feb 13, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 3 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@adriankalafut
Copy link
Contributor Author

adriankalafut commented Feb 13, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 3 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@adriankalafut
Copy link
Contributor Author

adriankalafut commented Feb 13, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@adriankalafut
Copy link
Contributor Author

!build

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 3 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@adriankalafut
Copy link
Contributor Author

adriankalafut commented Feb 14, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@adriankalafut
Copy link
Contributor Author

!build

@adriankalafut
Copy link
Contributor Author

adriankalafut commented Feb 14, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 3 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 3 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

Copy link
Contributor

@Zech-Hein Zech-Hein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriankalafut
Copy link
Contributor Author

The reported build failures are unrelated to this code change (com.ibm.websphere.appserver.features:test). This build break is common among multiple build failures right now and is being investigated.
Will go ahead and merge this PR since the remaining tests ran successfully.

@adriankalafut adriankalafut merged commit 758f0ef into OpenLiberty:integration Feb 14, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants