Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better logging for shared libs #30788

Conversation

benjamin-confino
Copy link
Member

@benjamin-confino benjamin-confino commented Feb 13, 2025

Resolves #30787

A small additional toString for better logging.

@benjamin-confino benjamin-confino force-pushed the 30787-better-logging-for-sharedlib branch from 2e26a96 to b3ee213 Compare February 13, 2025 12:02
Copy link
Member

@joe-chacko joe-chacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work — some slight improvements suggested

@benjamin-confino benjamin-confino force-pushed the 30787-better-logging-for-sharedlib branch from 68af34d to 1889bf0 Compare February 13, 2025 13:49
@benjamin-confino
Copy link
Member Author

benjamin-confino commented Feb 13, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@joe-chacko joe-chacko self-requested a review February 13, 2025 14:09
@joe-chacko joe-chacko self-requested a review February 13, 2025 14:36
Copy link
Member

@joe-chacko joe-chacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@benjamin-confino
Copy link
Member Author

benjamin-confino commented Feb 14, 2025

#libby (view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@benjamin-confino benjamin-confino merged commit 420f3ed into OpenLiberty:integration Feb 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging for com.ibm.ws.library.internal.SharedLibraryImpl doesn't actually tell you what is or isn't included
3 participants