Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[for 0.10] Remove EPoll delay #1802

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Conversation

DaAwesomeP
Copy link
Member

This is a cherry-picked duplicate of #1801 for v0.10.

Possible milestone #1792

cc @peternewman

@peternewman peternewman added this to the 0.10.9 milestone Dec 5, 2022
Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaAwesomeP , but could we just have the changes to EPoller.cpp in here, not the test program too please.

@DaAwesomeP
Copy link
Member Author

@peternewman Fixed!

@peternewman peternewman changed the title [for 0.10] Remove EPoll delay, add multi-universe throughput example [for 0.10] Remove EPoll delay Dec 6, 2022
Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @DaAwesomeP .

Feel free to add yourself to AUTHORS too:
https://github.com/OpenLightingProject/ola/blob/0.10/AUTHORS

@DaAwesomeP
Copy link
Member Author

Feel free to add yourself to AUTHORS too:
https://github.com/OpenLightingProject/ola/blob/0.10/AUTHORS

Adding! One moment please.

@DaAwesomeP
Copy link
Member Author

Done!

@peternewman
Copy link
Member

Sorry can you pull 0.10 or rebase too as I snuck another commit in there!

@DaAwesomeP
Copy link
Member Author

Sorry can you pull 0.10 or rebase too as I snuck another commit in there!

Done!

@peternewman peternewman merged commit 2a98331 into OpenLightingProject:0.10 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StreamingClient cannot process multiple universes but OlaClient can
2 participants