Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pack and unpack UIDSets #1830

Merged
merged 4 commits into from
Mar 5, 2023
Merged

Pack and unpack UIDSets #1830

merged 4 commits into from
Mar 5, 2023

Conversation

peternewman
Copy link
Member

Reduces the differences to review later in #1612

@peternewman
Add the ability to pack UIDSets
d902506 
(cherry picked from commit bd619c2)
@peternewman
Add the ability to make a UID set from binary data
34d77dd 
(cherry picked from commit dc06b8a)
@peternewman
Fix the Doxygen
ec25eee 
(cherry picked from commit a89f3db)
@peternewman peternewman added this to the 0.11.0 milestone Mar 5, 2023
@peternewman peternewman requested a review from kripton March 5, 2023 20:47
kripton
kripton approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@kripton kripton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all reasonable to me, tests are PASSed on my machine

@peternewman peternewman enabled auto-merge March 5, 2023 21:54
@peternewman peternewman merged commit 41c8ea5 into OpenLightingProject:master Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripton kripton kripton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@peternewman @kripton