Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore more minified files that might contain spelling false positives #1936

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Ignore more minified files that might contain spelling false positives #1936

merged 1 commit into from
Feb 26, 2024

Conversation

peternewman
Copy link
Member

Fixes our broken CI and hence resolves the issues in #1935 !

@peternewman peternewman added this to the 0.10.10 milestone Feb 26, 2024
@peternewman peternewman requested a review from kripton February 26, 2024 22:10
kripton
kripton approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@kripton kripton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, not the best idea to spellcheck minified gibberish

@peternewman
Copy link
Member Author

Although it's actually picked up what it thinks is a genuine typo, it just happens to be a false positive as it's a special Javascript word!

@peternewman peternewman merged commit 197e2f0 into OpenLightingProject:0.10 Feb 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripton kripton kripton approved these changes

Assignees

@kripton kripton

Labels
None yet
Projects
None yet
Milestone
0.10.10
Development

Successfully merging this pull request may close these issues.
2 participants
@peternewman @kripton