Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to variable tests + minor cleanup #194

Merged
merged 15 commits into from
Mar 27, 2024
Merged

Improvements to variable tests + minor cleanup #194

merged 15 commits into from
Mar 27, 2024

Conversation

jkirk5
Copy link
Contributor

@jkirk5 jkirk5 commented Mar 25, 2024 •
edited
Loading

Summary

  • Improvements to variable testing
    • now comparing both hierarchy and metadata with each other (both lists must match)
    • All variables in hierarchy are now included in all variable tests
  • Renamed fortran_to_aviary.py for PEP8 compliance
  • Added SPECIFIC_ENERGY and MACH_RATE to be consistent with other variables that include both state and state rate in the variable hierarchy
  • Added tempdirs flag to some tests to reduce clutter when running tests
  • Updates to converters
    • Added timestamp & user heading to fortran_to_aviary
    • Fixed engine type choices not properly rendering when using -h/--help for engine conversion utility
    • Merged -v and -vv args, with the expectation that we eventually support QUIET debug mode too, so having unique flags for each will be unwieldly

@jkirk5 jkirk5 requested review from crecine and johnjasa March 27, 2024 19:46
@johnjasa johnjasa added this pull request to the merge queue Mar 27, 2024
Merged via the queue into OpenMDAO:main with commit 654a399 Mar 27, 2024
7 checks passed
crecine
crecine reviewed Mar 27, 2024
View reviewed changes
aviary/utils/fortran_to_aviary.py
@@ -88,15 +97,16 @@ def create_aviary_deck(fortran_deck: str, legacy_code=None, defaults_deck=None,
out_file = fortran_deck.parent / out_file

if out_file.is_file():
if force:
if force and verbosity.value >= 1:
Copy link
Contributor

@crecine crecine Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this cause an error (the else path) if verbosity is quiet, even if force is True?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crecine crecine crecine left review comments

@Kenneth-T-Moore Kenneth-T-Moore Kenneth-T-Moore approved these changes

@johnjasa johnjasa johnjasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkirk5 @Kenneth-T-Moore @johnjasa @crecine