Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new detailed takeoff and landing docs #197

Merged
merged 14 commits into from
Apr 3, 2024

Conversation

johnjasa
Copy link
Member

@johnjasa johnjasa commented Mar 27, 2024

Summary

  • improved convergence of the takeoff case
  • added docs for the takeoff and landing examples
  • added nice output for takeoff and landing

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

Copy link
Contributor

@crecine crecine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments

aviary/docs/examples/images/takeoff.png Outdated Show resolved Hide resolved

In these examples we only model the takeoff and landing trajectories individually, not as part of a full mission.
This is because acoustic certification is typically done for these phases separately.
However, you can easily combine these phases into a full mission by adding the takeoff and landing phases to the mission.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by this, you mean adding the detailed TO before the flight phases and the detailed landing after them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call Ken, I changed the sentence to "However, you can easily combine these phases into a comprehensive mission by adding the takeoff, flight, and landing phases to the mission in that order."

@johnjasa johnjasa added this pull request to the merge queue Apr 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2024
@johnjasa johnjasa added this pull request to the merge queue Apr 3, 2024
Merged via the queue into OpenMDAO:main with commit f79d73a Apr 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants