Split EQUIPMENT_MASS_COEFFICIENTS to 13 individual variables #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait for me. I will reuse variables from FLOPS. |
jkirk5
approved these changes
Apr 16, 2024
| @@ -972,6 +1020,18 @@ | |||
| desc='Drag polar computed during Aviary pre-mission.', | |||
| ) | |||
|
|
|||
| add_meta_data( | |||
| Aircraft.Design.EMERGENCY_MASS, | |||
There was a problem hiding this comment.
@crecine does GASP have any additional information on what's included in emergency mass? Design is an ok place to put it if it doesn't neatly fit into any of our other categories
There was a problem hiding this comment.
I'll see if I can find any more detailed information, but it's the cabin emergency equipment (fire extinguishers, oxygen tanks, smoke hoods, etc)
I think design is an appropriate place for it.
| @@ -3374,6 +3434,30 @@ | |||
| # |___/ | |||
| # ==================================================================== | |||
|
|
|||
| add_meta_data( | |||
| Aircraft.Hydraulics.FC_MASS_COEFFICIENT, | |||
There was a problem hiding this comment.
Suggested change
| Aircraft.Hydraulics.FC_MASS_COEFFICIENT, | |
| Aircraft.Hydraulics.FLIGHT_CONTROL_MASS_COEFFICIENT, |
There was a problem hiding this comment.
If this variable gets changed, the new name needs to get updated throughout the code
crecine
reviewed
Apr 16, 2024
aviary/subsystems/mass/gasp_based/test/test_equipment_and_useful_load.py
Outdated
Show resolved
Hide resolved
aviary/subsystems/mass/gasp_based/test/test_equipment_and_useful_load.py
Outdated
Show resolved
Hide resolved
aviary/subsystems/mass/gasp_based/test/test_equipment_and_useful_load.py
Outdated
Show resolved
Hide resolved
crecine
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR splits EQUIPMENT_MASS_COEFFICIENTS to 13 individual variables. They are (in the same order):
All of them have units "unitless" or "lbm". Once this change is merged to Aviary, we can claim that all Aviary variables have appropriate units.
These variables correspond to
CW(1), ..., CW(13)in GASP.Note that
CW(5)has two different units (lb or lb/pax) in the new version of GASP. In the above, I only consider one unit:lbm.Also note that the new version of GASP has extended
CWarray to 16 entries.CW(15)is the electrical Systems weight per passenger. Aviary has this weight inequipment_and_useful_load.pyalready. So, I suggest a new variable:ELECTRICAL_MASS_PER_PASSENGER: mass of electrical system per passenger (lbm)
CW(14)is cargo handling. CW(16) is other operating items. They both default to 0.0. Aviary does not have them. We can add them later.Related Issues
Backwards incompatibilities
None
New Dependencies
None