Update inconsistent naming for angle of attack #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he variable now stored in the variable meta data.
aviary/models/N3CC/N3CC_data.py
Outdated
| @@ -1606,7 +1606,7 @@ def _split_aviary_values(aviary_values, slicing): | |||
| landing_fullstop_initial_guesses.set_val('velocity', [135., 0.01], 'kn') | |||
| landing_fullstop_initial_guesses.set_val('mass', detailed_landing_mass, 'lbm') | |||
| landing_fullstop_initial_guesses.set_val('throttle', 0.) | |||
| landing_fullstop_initial_guesses.set_val('angle_of_attack', 0., 'deg') | |||
| landing_fullstop_initial_guesses.set_val(Dynamic.Vehicle.ANGLE_OF_ATTACK, 0., 'deg') | |||
There was a problem hiding this comment.
Looks like you did a global search and replace, which is a good way to do this. For this N3CC data file though, it looks like we haven't updated any of the other dynamic variables (velocity, mass, etc.).
Kenneth-T-Moore
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will pull in Task152 branch from the nathanperreau/Aviary forked repository. The branch focuses on modifying 'angle_of_attack' strings that exist in various files through the Aviary directory. They are being replaced with a standardized variable stored in the meta data.
Related Issues
Backwards incompatibilities
None
New Dependencies
None