Skip to content

Commit

Permalink
[Fix] S3M: Rework r20871. The file sounds broken in Impulse Tracker, …
Browse files Browse the repository at this point in the history
…which the sample text even warns about.

git-svn-id: https://source.openmpt.org/svn/openmpt/trunk/OpenMPT@20893 56274372-70c3-4bfc-bfc3-4c3a0b034d27
  • Loading branch information
sagamusix committed Jun 1, 2024
1 parent 0d0d663 commit 39cd622
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions soundlib/Load_s3m.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ bool CSoundFile::ReadS3M(FileReader &file, ModLoadingFlags loadFlags)
m_playBehaviour.set(kITRetrigger);
m_playBehaviour.set(kITShortSampleRetrig);
m_playBehaviour.set(kST3SampleSwap); // Not exactly like ST3, but close enough
// alien.s3m by Davers (pattern 13) needs these to play the Gxx with sample switch as intended
m_playBehaviour.set(kITPortaNoNote);
m_playBehaviour.set(kITPortamentoSwapResetsPos);
m_nMinPeriod = 1;
Expand Down Expand Up @@ -374,7 +373,7 @@ bool CSoundFile::ReadS3M(FileReader &file, ModLoadingFlags loadFlags)
{
m_playBehaviour.reset(kST3NoMutedChannels);
m_playBehaviour.reset(kST3EffectMemory);
m_playBehaviour.set(kST3PortaSampleChange, (fileHeader.cwtv& S3MFileHeader::trackerMask) == S3MFileHeader::trkImpulseTracker);
m_playBehaviour.reset(kST3PortaSampleChange);
m_playBehaviour.reset(kST3VibratoMemory);
m_playBehaviour.reset(KST3PortaAfterArpeggio);
m_playBehaviour.reset(kST3OffsetWithoutInstrument);
Expand Down

0 comments on commit 39cd622

Please sign in to comment.