Rename arg pull worker_image_service.build to pull_image

to be consistent with worker_pool_service.create_image_and_pool_request
OpenMined · May 31, 2024 · 270d053 · 270d053
1 parent f3f8eb4
commit 270d053
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/notebooks/api/0.8/10-container-images.ipynb b/notebooks/api/0.8/10-container-images.ipynb
@@ -393,7 +393,7 @@
     "    image_uid=workerimage.id,\n",
     "    tag=docker_tag,\n",
     "    registry_uid=registry_uid,\n",
-    "    pull=pull,\n",
+    "    pull_image=pull,\n",
     ")\n",
     "docker_build_result"
    ]
@@ -1483,7 +1483,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.11.7"
+   "version": "3.12.2"
   }
  },
  "nbformat": 4,

diff --git a/packages/syft/src/syft/node/node.py b/packages/syft/src/syft/node/node.py
@@ -1741,7 +1741,7 @@ def create_default_worker_pool(node: Node) -> SyftError | None:
             context,
             image_uid=default_image.id,
             tag=DEFAULT_WORKER_IMAGE_TAG,
-            pull=pull_image,
+            pull_image=pull_image,
         )
 
         if isinstance(result, SyftError):

diff --git a/packages/syft/src/syft/service/request/request.py b/packages/syft/src/syft/service/request/request.py
@@ -251,7 +251,7 @@ def _run(
                     image_uid=worker_image.id,
                     tag=self.tag,
                     registry_uid=self.registry_uid,
-                    pull=self.pull_image,
+                    pull_image=self.pull_image,
                 )
 
                 if isinstance(build_result, SyftError):

diff --git a/packages/syft/src/syft/service/worker/worker_image_service.py b/packages/syft/src/syft/service/worker/worker_image_service.py
@@ -82,7 +82,7 @@ def build(
         image_uid: UID,
         tag: str,
         registry_uid: UID | None = None,
-        pull: bool = True,
+        pull_image: bool = True,
     ) -> SyftSuccess | SyftError:
         registry: SyftImageRegistry | None = None
 
@@ -130,7 +130,7 @@ def build(
         result = None
 
         if not context.node.in_memory_workers:
-            build_result = image_build(worker_image, pull=pull)
+            build_result = image_build(worker_image, pull=pull_image)
             if isinstance(build_result, SyftError):
                 return build_result