moved reg username and password to request.approve()

OpenMined · Feb 16, 2024 · 61a5f3b · 61a5f3b
1 parent 4014c66
commit 61a5f3b
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/notebooks/api/0.8/11-container-images-k8s.ipynb b/notebooks/api/0.8/11-container-images-k8s.ipynb
@@ -1072,11 +1072,7 @@
    "source": [
     "pool_name_opendp = \"opendp-pool\"\n",
     "pool_create_request = domain_client.api.services.worker_pool.pool_creation_request(\n",
-    "    pool_name=pool_name_opendp,\n",
-    "    num_workers=3,\n",
-    "    image_uid=workerimage_opendp.id,\n",
-    "    reg_username=external_registry_username,\n",
-    "    reg_password=external_registry_password,\n",
+    "    pool_name=pool_name_opendp, num_workers=3, image_uid=workerimage_opendp.id\n",
     ")\n",
     "pool_create_request"
    ]
@@ -1100,7 +1096,9 @@
    "outputs": [],
    "source": [
     "# get the pending request and approve it\n",
-    "req_result = pool_create_request.approve()\n",
+    "req_result = pool_create_request.approve(\n",
+    "    reg_username=external_registry_username, reg_password=external_registry_password\n",
+    ")\n",
     "req_result"
    ]
   },