Helm #8085
Merged
Helm #8085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
4 tasks
Remove API_KEY to force people to set them in their own environments.
kiendang
reviewed
Dec 1, 2023
kiendang
reviewed
Dec 1, 2023
Remove unused script / fix seaweedfs docker entrypoint
ADD missing env vars in default.env
- Added SyftLock to prevent concurrent writes as SQLite doesn't like it - Changed Connection re-use to prevent explosion of open files - Changed destructor to only close connection on last __del__ - NOTE: This might be a bit slower, we can attempt to improve if it works - Added scripts/print_fd.py debug tool for showing open file descriptors co-author: @tcp
Fix SQLite File Descriptor Leak
dont merge: CI filedescriptor debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.