Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve notifications html #8106

Merged
merged 9 commits into from
Oct 2, 2023
Merged

feat: improve notifications html #8106

merged 9 commits into from
Oct 2, 2023

Conversation

tcp
Copy link
Collaborator

@tcp tcp commented Sep 21, 2023

Description

  • Updates the html for a single notification
  • Ensures client.notifications shows all notifications instead of only unread
    • The service does get_all instead of a custom get_all_unread
    • No change to client.notifications.get_all_unread or client.notifications.get_all_read

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Notebook 03
  • Tox notebook test

Checklist

tcp added 2 commits September 21, 2023 17:04
@tcp
lint: fix linked_obj.py
bdec003
@tcp
fix: adds uploader to dataset/asset
abc1f90 
A contributor added with the role of "Uploader" is also added to the
dataset and asset as the "uploader".
@tcp tcp changed the title feat: improve single notification html feat: improve notifications html Sep 21, 2023
@tcp tcp enabled auto-merge September 25, 2023 08:38
@tcp tcp merged commit c0d3000 into dev Oct 2, 2023
@tcp tcp deleted the feat/notifications_object_repr branch October 2, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IonesioJunior IonesioJunior IonesioJunior approved these changes

@IrinaMBejan IrinaMBejan IrinaMBejan approved these changes

Assignees
No one assigned
Labels
0.8.2 Green Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcp @IrinaMBejan @IonesioJunior @madhavajay