Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show uploader if exists #8107

Merged
merged 11 commits into from
Oct 5, 2023
Merged

fix: show uploader if exists #8107

merged 11 commits into from
Oct 5, 2023

Conversation

tcp
Copy link
Collaborator

@tcp tcp commented Sep 21, 2023

Description

A contributor added with the role of "Uploader" is also added to the dataset and asset as the "uploader".

How has this been tested?

  • Dataset notebook

Checklist

@tcp
fix: adds uploader to dataset/asset
4af628f 
A contributor added with the role of "Uploader" is also added to the
dataset and asset as the "uploader".
@tcp tcp requested a review from IonesioJunior September 21, 2023 16:55
@tcp tcp changed the title fix: adds uploader to dataset/asset fix: only show uploader if it exists Sep 21, 2023
@tcp tcp changed the title fix: only show uploader if it exists fix: show uploader if exists Sep 21, 2023
@tcp tcp enabled auto-merge September 25, 2023 11:23
@tcp tcp removed the request for review from IonesioJunior October 5, 2023 11:17
@tcp tcp disabled auto-merge October 5, 2023 11:18
@tcp tcp merged commit 54d0e5c into dev Oct 5, 2023
29 of 30 checks passed
@tcp tcp deleted the fix/dataset_assets_contributor_uploader branch October 5, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IonesioJunior IonesioJunior IonesioJunior approved these changes

Assignees

@tcp tcp

Labels
0.8.2 Green Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcp @IonesioJunior @madhavajay