fix: hagrind land all --prune-vol can delete volumes from other containers
#8118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khoaguin
changed the title
-f when pruning volumes to ask for confirmation
khoaguin
changed the title
hagrind land all --prune-vol can delete volumes from other containers
- Removing the syft volumes according to labels when doing `hagrid land all --prune-vol` Co-authored-by: Madhava Jay <[email protected]>
- only remove syft's containers when doing `hagrid land all`
4 tasks
shubham3121
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Great work @khoaguin 🎉 !! This solves one of the long running pain points.
|
Thanks a lot for the kind words @shubham3121. We probably need a test or two for this? |
khoaguin
deleted the
bugfix/hagrid-land-can-delete-volumes-from-other-containers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: HAGrid can delete volumes from other containers#751