-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seaweed FS to devspace/k8s #8119
Conversation
- port: "8888" # filer | ||
- port: "8333" # S3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if we need to expose these ports, else I can move them under "dev"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave these to under dev
only.
I'll test this out before I remove the [WIP] tag |
@madhavajay @rasswanth-s tested the kubernetes deployments. I had to tweak |
I will review this but, excellent work @yashgorana this is my favourite PR of the week! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I needed to add localhost
to the default hostname for the changes to ingress when running in k3d, but other than that everything worked.
I imagine we might have some more to, do once we get the tests running again but for now this is ready for merge!
Definitely PR of the week! Keep it up. ❤️
Description
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist