Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seaweed FS to devspace/k8s #8119

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Add Seaweed FS to devspace/k8s #8119

merged 7 commits into from
Oct 3, 2023

Conversation

yashgorana
Copy link
Contributor

@yashgorana yashgorana commented Sep 27, 2023

Description

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Comment on lines +276 to +277
- port: "8888" # filer
- port: "8333" # S3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if we need to expose these ports, else I can move them under "dev"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave these to under dev only.

@yashgorana
Copy link
Contributor Author

I'll test this out before I remove the [WIP] tag

@yashgorana yashgorana changed the title [WIP] Add Seaweed FS to devspace/k8s Add Seaweed FS to devspace/k8s Sep 28, 2023
@yashgorana
Copy link
Contributor Author

@madhavajay @rasswanth-s tested the kubernetes deployments. I had to tweak tox.ini & helm.py because the final helm yaml files were missing apiVersion key in some cases. Aditionally, the file names follow helm's convention & i've updated the component-chart to 0.9.1.

Emply cluster on dev
empty-cluster

Helm install on dev
deploy-tot

Helm update on this branch (with seaweed-fs)
deploy-seaweed

@madhavajay
Copy link
Collaborator

I will review this but, excellent work @yashgorana this is my favourite PR of the week! 🙌

Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I needed to add localhost to the default hostname for the changes to ingress when running in k3d, but other than that everything worked.

I imagine we might have some more to, do once we get the tests running again but for now this is ready for merge!

Definitely PR of the week! Keep it up. ❤️

@madhavajay madhavajay merged commit 79a5ec4 into dev Oct 3, 2023
@madhavajay madhavajay deleted the yash/devspace-seaweed branch October 3, 2023 05:00
@yashgorana yashgorana self-assigned this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants