Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra prompts on .accept_by_depositing_result #8134

Merged
merged 5 commits into from
Oct 6, 2023

Conversation

rasswanth-s
Copy link
Collaborator

@rasswanth-s rasswanth-s commented Oct 5, 2023

Since, we have .set function at various stages of our code, the PR moves prompts to high level functions to prevent repetitive prompts at request level.

Resolves: https://github.com/OpenMined/Heartbeat/issues/737

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

add prompts during datasets upload
@rasswanth-s rasswanth-s enabled auto-merge October 6, 2023 08:18
@rasswanth-s rasswanth-s disabled auto-merge October 6, 2023 08:18
@rasswanth-s
Copy link
Collaborator Author

Received a review from @shubham3121 , hence merging the same

@rasswanth-s rasswanth-s merged commit b26a62f into dev Oct 6, 2023
30 checks passed
@rasswanth-s rasswanth-s deleted the rasswanth/remove_extra_prompts branch October 6, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant