Demo improvements #8137
Merged
Demo improvements #8137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| kwargs=kwargs, context=context, code_item_id=code_item.id | ||
| ) | ||
| code_item.input_policy = input_policy |
There was a problem hiding this comment.
why is this needed?
There was a problem hiding this comment.
if you check the UserCode class, you can see that the input policy is actually a property that also has a setter method, so in order to save the state we need to do this. This is exactly the same mechanism as the one for the output policy
|
great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are multiple changes meant to improve the flow of a future helm demo:
file.iter_lines()and processingnew policy-> moved to ExecuteOncePerCombination Policy #8160ExecuteOncePerCombinationHow has this been tested?
Checklist