Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing for search results #8143

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix indexing for search results #8143

merged 1 commit into from
Oct 10, 2023

Conversation

IonesioJunior
Copy link
Member

@IonesioJunior IonesioJunior commented Oct 10, 2023

Description

Previously, when conducting a search in our table, clicking on a page index would reset the view to display all elements, rather than maintaining the filtered search results. We have now implemented a fix to ensure that pagination is applied exclusively to the elements within our search results.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@IonesioJunior IonesioJunior requested a review from tcp October 10, 2023 12:05
Copy link
Collaborator

@tcp tcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one-liner wins

@IonesioJunior IonesioJunior merged commit c372054 into dev Oct 10, 2023
@IonesioJunior IonesioJunior deleted the fix_search_table branch October 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants